[1/15] Route error responses back through the interceptor chain - #154
Open
UnknownJoe796 wants to merge 2 commits into
Open
[1/15] Route error responses back through the interceptor chain#154UnknownJoe796 wants to merge 2 commits into
UnknownJoe796 wants to merge 2 commits into
Conversation
Map handler, routing, timeout, and compression exceptions to HTTP responses *inside* the compiled interceptor chain instead of outside it, so error responses still receive interceptor post-processing. The motivating case is CORS: without this, 4xx/5xx responses shipped without Access-Control-Allow-Origin, and browsers masked the real error as a generic CORS failure. An outer catch remains as a safety net for exceptions thrown by an interceptor itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 3a5031f)
iHoonter
self-requested a review
July 31, 2026 22:22
iHoonter
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception short-circuited the interceptor chain, so responses built from
errors skipped everything downstream -- logging, headers, CORS. Error responses
now travel back through the chain.